fix: only save package-lock when truly finished #6095
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we update the trees, the edges are refreshed to correct their specs. If we have written the package-lock before this point, it will be incorrect. No new tests are needed as existing tests were snapshotted w/ the broken behavior, and are fixed now showing this bugfix in action.
Member
Author
|
Closes #5587 |
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we update the trees, the edges are refreshed to correct their
specs. If we have written the package-lock before this point, it will
be incorrect.
No new tests are needed as existing tests were snapshotted w/ the broken
behavior, and are fixed now showing this bugfix in action.
A potential unhandled exception was removed when the promises array was being made, but only awaited after the for loop was done.
Finally, there was a spurious snapshot that I also removed before changing any code so that the fix commit could only show the bugfix changes.