Skip to content

fix: Validate username at get-identity #5884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fritzy merged 4 commits into from
Nov 30, 2022
Merged

fix: Validate username at get-identity #5884

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
60ee40c
Update get-identity.js
sosoba Nov 22, 2022
2571d95
Update get-identity.js
sosoba Nov 22, 2022
373676b
Update lib/utils/get-identity.js
sosoba Nov 25, 2022
18f0121
fixup! Update lib/utils/get-identity.js
nlf Nov 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/utils/get-identity.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,9 @@ module.exports = async (npm, opts) => {
// No username, but we have other credentials; fetch the username from registry
if (creds.token || creds.certfile && creds.keyfile) {
const registryData = await npmFetch.json('/-/whoami', { ...opts })
return registryData.username
if (typeof registryData?.username === 'string') {
return registryData.username
}
}

// At this point, even if they have a credentials object, it doesn't have a
Expand Down