Skip to content

feat: remove npm birthday #5455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wraithgar merged 1 commit into from
Sep 8, 2022
Merged

feat: remove npm birthday #5455

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 0 additions & 17 deletions lib/commands/birthday.js
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion lib/utils/cmd-list.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ const cmdList = [
'whoami',
]

const plumbing = ['birthday', 'help-search']
const plumbing = ['help-search']
const abbrevs = abbrev(cmdList.concat(Object.keys(aliases)))

module.exports = {
Expand Down
9 changes: 0 additions & 9 deletions tap-snapshots/test/lib/load-all-commands.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,15 +57,6 @@ Options:
Run "npm help audit" for more info
`

exports[`test/lib/load-all-commands.js TAP load each command birthday > must match snapshot 1`] = `
Birthday, deprecated

Usage:
npm birthday

Run "npm help birthday" for more info
`

exports[`test/lib/load-all-commands.js TAP load each command bugs > must match snapshot 1`] = `
Report bugs for a package in a web browser

Expand Down
1 change: 0 additions & 1 deletion tap-snapshots/test/lib/utils/cmd-list.js.test.cjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -474,7 +474,6 @@ Object {
"whoami",
],
"plumbing": Array [
"birthday",
"help-search",
],
}
Expand Down
15 changes: 0 additions & 15 deletions test/lib/commands/birthday.js
View file
Open in desktop

This file was deleted.

4 changes: 2 additions & 2 deletions test/lib/npm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,10 +574,10 @@ t.test('aliases and typos', async t => {
const { npm } = await loadMockNpm(t, { load: false })
await t.rejects(npm.cmd('thisisnotacommand'), { code: 'EUNKNOWNCOMMAND' })
await t.rejects(npm.cmd(''), { code: 'EUNKNOWNCOMMAND' })
await t.rejects(npm.cmd('birt'), { code: 'EUNKNOWNCOMMAND' })
await t.rejects(npm.cmd('birthday'), { code: 'EUNKNOWNCOMMAND' })
await t.resolves(npm.cmd('it'), { name: 'install-test' })
await t.resolves(npm.cmd('installTe'), { name: 'install-test' })
await t.resolves(npm.cmd('birthday'), { name: 'birthday' })
await t.resolves(npm.cmd('access'), { name: 'access' })
})

t.test('explicit workspace rejection', async t => {
Expand Down