Skip to content

fix(install): do not install invalid package name #4679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lukekarrys merged 1 commit into from
Apr 19, 2022
Merged

fix(install): do not install invalid package name #4679

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/commands/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,12 @@ class Install extends ArboristWorkspaceCmd {
args = ['.']
}

// throw usage error if trying to install empty package
// name to global space, e.g: `npm i -g ""`
if (where === globalTop && !args.every(Boolean)) {
throw this.usageError()
}

const opts = {
...this.npm.flatOptions,
auditLevel: null,
Expand Down
17 changes: 17 additions & 0 deletions test/lib/commands/install.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,6 +139,23 @@ t.test('should install globally using Arborist', async t => {
t.strictSame(SCRIPTS, [], 'no scripts when installing globally')
})

t.test('should not install invalid global package name', async t => {
const { npm } = await loadMockNpm(t, {
'@npmcli/run-script': () => {},
'../../lib/utils/reify-finish.js': async () => {},
'@npmcli/arborist': function (args) {
throw new Error('should not reify')
},
})
npm.config.set('global', true)
npm.globalPrefix = path.resolve(t.testdir({}))
await t.rejects(
npm.exec('install', ['']),
/Usage:/,
'should not install invalid package name'
)
})

t.test('npm i -g npm engines check success', async t => {
const { npm } = await loadMockNpm(t, {
'../../lib/utils/reify-finish.js': async () => {},
Expand Down