fix(arborist): identify and repair invalid nodes in the virtual tree #4599
+30
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
approved these changes
Mar 23, 2022
Member
wraithgar
left a comment
wraithgar
left a comment
There was a problem hiding this comment.
The tests really tell the story here.
by loading the overrides on the root of the virtual tree, we effectively ensure that `npm ci` will throw an error when your package.json overrides are not in sync with the tree in your package-lock.json
|
Looks like github actions didn't run the tests on bf919a5, probably was caught up in the github downtime @nlf @wraithgar |
Contributor
Author
it sure was. i ran a manual pass of the ci workflow, results here (tl;dr all green): https://github.com/npm/cli/actions/runs/2053519458 |
|
If I could hit merge I would. 😁 |
|
What is the version this will be released to? Next 8.5.x? Or other version too? Thanks a lot |
Member
|
The next v8 version |
Merged
This was referenced Apr 1, 2022
Closed
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the effect after this change is that a pre-existing tree (either virtual from a package-lock, or actual from node_modules) will have any invalid edges repaired.
these invalid edges could be due to:
closes #4422
closes #4232