Skip to content

Conversation

@XhmikosR
Copy link
Contributor

@XhmikosR XhmikosR commented Feb 23, 2022

References

Spotted on https://lgtm.com/projects/g/npm/cli/alerts/?mode=list. If you are not using CodeQL already, I suggest that you set it up :)

@XhmikosR XhmikosR requested a review from a team as a code owner February 23, 2022 14:10
@ljharb
Copy link
Contributor

ljharb commented Feb 23, 2022

Not sure why codeql would be needed; this is an eslint core rule (that should certainly be enabled)

@XhmikosR
Copy link
Contributor Author

Whatever does the job, ofc. It's just that CodeQL has checks for things ESLint doesn't.

@wraithgar
Copy link
Member

We are setting codeql up on our repos, we have not done it for the cli yet but it's on the roadmap.

@lukekarrys
Copy link
Contributor

Not sure why codeql would be needed; this is an eslint core rule (that should certainly be enabled)

@ljharb what's the eslint rule for this?

@ljharb
Copy link
Contributor

ljharb commented Feb 23, 2022

@lukekarrys lukekarrys merged commit 5a31926 into npm:latest Feb 23, 2022
@XhmikosR XhmikosR deleted the patch-1 branch February 23, 2022 18:43
@lukekarrys lukekarrys mentioned this pull request Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants