Skip to content

fix: some commands should ignore workspaces #4439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mshima wants to merge 2 commits into from
Closed

fix: some commands should ignore workspaces #4439

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
13dde86
fix: some commands should ignore workspaces
mshima Feb 18, 2022
44a1518
Add more commands
mshima Feb 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion lib/npm.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,9 @@ class Npm extends EventEmitter {
throw new Error('Can not use --no-workspaces and --workspace at the same time')
}

const filterByWorkspaces = workspacesEnabled || workspacesFilters.length > 0
const filterByWorkspaces =
!['bin', 'cache', 'completion', 'doctor', 'get', 'help', 'owner', 'prefix', 'whoami'].includes(this.command) &&
(workspacesEnabled || workspacesFilters.length > 0)
// normally this would go in the constructor, but our tests don't
// actually use a real npm object so this.npm.config isn't always
// populated. this is the compromise until we can make that a reality
Expand Down