Skip to content

Conversation

@nlf
Copy link
Contributor

@nlf nlf commented Jan 6, 2022

according to this issue node-modules/agentkeepalive#57 this update fixes a race condition that could cause timeouts to cause problems. bringing in this update is worth a shot to potentially fix another source of exit handler not called errors.

@nlf nlf requested a review from a team as a code owner January 6, 2022 18:10
@npm-robot
Copy link
Contributor

found 20 benchmarks with statistically significant performance improvements

  • app-large: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
  • app-medium: clean, lock-only, cache-only, cache-only:peer-deps, modules-only, no-lock, no-cache, no-modules, no-clean, no-clean:audit
timing results
app-large clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 45.590 ±1.02 26.258 ±0.49 15.574 ±0.34 16.662 ±1.03 2.421 ±0.01 2.439 ±0.01 1.955 ±0.03 9.896 ±0.25 2.011 ±0.08 2.913 ±0.19
#4213 0.357 ±0.00 0.378 ±0.00 0.350 ±0.00 0.348 ±0.01 0.378 ±0.00 0.346 ±0.01 0.369 ±0.01 0.348 ±0.01 0.367 ±0.00 0.360 ±0.03
app-medium clean lock-only cache-only cache-only
peer-deps
modules-only no-lock no-cache no-modules no-clean no-clean
audit
npm@8 32.844 ±0.02 19.565 ±0.12 11.281 ±0.66 12.097 ±0.84 2.229 ±0.01 2.225 ±0.01 2.034 ±0.00 7.593 ±0.01 1.853 ±0.01 2.625 ±0.05
#4213 0.355 ±0.01 0.357 ±0.02 0.362 ±0.02 0.375 ±0.00 0.379 ±0.01 0.373 ±0.00 0.360 ±0.02 0.357 ±0.01 0.395 ±0.04 0.368 ±0.02

@nlf nlf merged commit 2e27bff into release-next Jan 6, 2022
@nlf nlf deleted the nlf/dep-agentkeepalive-4.2.0 branch January 6, 2022 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants