add token tests #1853
Closed
add token tests #1853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlf
force-pushed
the
nlf/add-token-tests
branch
from
d809b20 to
b170a85
Compare
darcyclarke
added
Release 7.x
ruyadorno
approved these changes
Sep 28, 2020
nlf
added a commit
that referenced
this pull request
Sep 29, 2020
PR-URL: #1853 Credit: @nlf Close: #1853 Reviewed-by: @ruyadorno
nlf
added a commit
that referenced
this pull request
Sep 29, 2020
PR-URL: #1853 Credit: @nlf Close: #1853 Reviewed-by: @ruyadorno
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds test coverage for the
npm tokencommand and fixes a couple of bugs along the way.i'm not 100% sold on the approach i took with the mocks. i like the isolation, but it's definitely verbose. i'll probably take another pass at shortening that up in the near future. i didn't see a reason to wait on that to get the tests landed though so here we are.