npx: add install prompt, handle options correctly #1596
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruyadorno
suggested changes
Aug 3, 2020
bin/npx-cli.js
Outdated
| const removedSwitches = new Set([ | ||
| 'always-spawn', | ||
| 'ignore-existing', | ||
| 'shell-auto-feedback' |
Contributor
There was a problem hiding this comment.
ooops, isn't it shell-auto-fallback ?
| } | ||
|
|
||
| if (removed.has(key)) { | ||
| console.error(`npx: the --${key} argument has been removed.`) |
Contributor
There was a problem hiding this comment.
I think it would be nice to have a more elaborate msg for some of these keys, or maybe just add a link to npm help exec (showing the "Compatibility with Older npx Versions" section) or to a blog post that explains the reasoning for the changes? as an user I would def appreciate that
- handle previous npx options that are still possible to be handled, and print a warning if any deprecated/removed options are used. - expand shorthands properly in npx command line. - take existing npm options into account when determining placement of the -- argument. - document changes from previous versions of npx.
isaacs
added a commit
that referenced
this pull request
Aug 4, 2020
- handle previous npx options that are still possible to be handled, and print a warning if any deprecated/removed options are used. - expand shorthands properly in npx command line. - take existing npm options into account when determining placement of the -- argument. - document changes from previous versions of npx. PR-URL: #1596 Credit: @isaacs Close: #1596 Reviewed-by: @ruyadorno
isaacs
added a commit
that referenced
this pull request
Aug 4, 2020
- handle previous npx options that are still possible to be handled, and print a warning if any deprecated/removed options are used. - expand shorthands properly in npx command line. - take existing npm options into account when determining placement of the -- argument. - document changes from previous versions of npx. PR-URL: #1596 Credit: @isaacs Close: #1596 Reviewed-by: @ruyadorno
jzacsh
added a commit
to jzacsh/dotfiles
that referenced
this pull request
Aug 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
print a warning if any deprecated/removed options are used.
the -- argument.