Skip to content

refactor: for readability #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jjangga0214 wants to merge 1 commit into from
Closed

refactor: for readability #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 14 additions & 18 deletions bin/npm-cli.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,10 +92,14 @@
const color = require('ansicolors')
const useColor = npm.config.get('color')
const useUnicode = npm.config.get('unicode')
const old = notifier.update.current
const latest = notifier.update.latest
let old = notifier.update.current
let latest = notifier.update.latest
let changelog = `https://github.com/npm/cli/releases/tag/v${latest}`
let type = notifier.update.type
if (useColor) {
old = color.red(old)
latest = color.green(latest)
changelog = color.cyan(changelog)
switch (type) {
case 'major':
type = color.red(type)
Expand All @@ -108,23 +112,15 @@
break
}
}
const changelog = `https://github.com/npm/cli/releases/tag/v${latest}`
notifier.notify({
message: `New ${type} version of ${pkg.name} available! ${
useColor ? color.red(old) : old
} ${useUnicode ? '→' : '->'} ${
useColor ? color.green(latest) : latest
}\n` +
`${
useColor ? color.yellow('Changelog:') : 'Changelog:'
} ${
useColor ? color.cyan(changelog) : changelog
}\n` +
`Run ${
useColor
? color.green(`npm install -g ${pkg.name}`)
: `npm i -g ${pkg.name}`
} to update!`
message: `New ${type} version of ${pkg.name} available!
${old} ${useUnicode ? '→' : '->'} ${latest}\n` +
`${useColor ? color.yellow('Changelog:') : 'Changelog:'} ${changelog}\n` +
`Run ${
useColor
? color.green(`npm install -g ${pkg.name}`)
: `npm i -g ${pkg.name}`
} to update!`
})
}
}
Expand Down