Provide CancellationToken as optional parameter to all methods, so requests can be cancelled or timed-out.

[pianomanjh]

It is common for APIs involving potentially long http requests, to accept a CancellationToken, such that a call can be cancelled, or timed-out by a user.
It would be fairly simple to add to this API, as it would be just need be passed down to the HttpClient, that accepts one in SendAsync.

[nozzlegear]

Good idea! In your mind, how would this look? An overload for each function on a service, making them all accept an optional token?

public List<Something> ListAsync(ListOptions options, CancellationToken token = null)
{
...
}

[pianomanjh]

yes, any method that results in an HttpRequest could accept an optional token.

[josh-degraw]

Any traction on this? This could be very helpful in my current use-cases.

IMO It would also be useful to update the ExequteRequestAsync<T> delegate and IRequestExecutionPolicy to either pass in a cancellation token as is, or add an overload that would have a CancellationToken, e.g. the Retry-able execution policies could support cancellation to avoid performance issues at runtime.

[nozzlegear]

I’m still open to this! If anyone has the time I’d be happy to review a pull request to get this added in.

[pianomanjh]

Alright, I can take a stab at this, standby

[pianomanjh]

PR posted: #476

[nozzlegear]

Published in 5.1.0 🚀