update minimum walkdir version to 2.2.2#432
Merged
JohnTitor merged 1 commit intonotify-rs:mainfrom Aug 15, 2022
Merged
Conversation
Contributor
Author
|
CI seems to have failed due to "1 cancelled checks" for macos-latest nightly. I'm not sure what that means or whether I can do something about it. Edit: someone seems to have restarted the job. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying out
notify 5.0.0-pre.16, I got some issues as it declare a dependency onwalkdir 2.0.1, but uses a function added in2.2.2. This patch aims to fix that little issue.I've tested the RC for my (arguably simple) use case, and on Linux it seems to work fine. I'll test on MacOS and Windows in the following days, and report if I got any issue.