replace old config and allow initialization configuration#426
Merged
Conversation
0xpr03
force-pushed
the
remove_live_config
branch
2 times, most recently
from
bf9b6e9 to
b1e8bac
Compare
0xpr03
force-pushed
the
remove_live_config
branch
4 times, most recently
from
9dc36f4 to
8682510
Compare
This also allows correct configuration of PollWatcher via notify-debouncer-mini
0xpr03
force-pushed
the
remove_live_config
branch
from
8682510 to
a0f35e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all event-level configuration, which is completely unimplemented by all backends.
Replaces them with the init-critical PollWatcher config. Allows configuration during initialization. Uses a builder pattern with defaults to allow future settings.
This way you can setup a recommended watcher while still specifying the wanted PollWatcher settings and the debouncer can initiate a PollWatcher with
compare_contents, something that can only be done pre runtime.Related #249
Closes #418