Merged
Conversation
Member
Author
|
cc @jhscheer would that be an appropriate fix for you ? |
Contributor
|
Yes, this looks very good and solves my issue. Thanks! |
Member
Author
|
Note that non-boxing would require an enum that matches the CFG chaos of RecommendedWatcher, adding an enum for every possible configurable watcher combination. And otherwise we'll have to add the specific config calls to the trait. |
JohnTitor
approved these changes
Sep 29, 2021
Member
JohnTitor
left a comment
JohnTitor
left a comment
There was a problem hiding this comment.
Overall LGTM with a few nits 👍
Comment on lines
+3
to
+11
| use notify::*; | ||
| fn main() { | ||
|
|
||
| let (tx, rx) = std::sync::mpsc::channel(); | ||
| let watcher: Box<dyn Watcher> = if RecommendedWatcher::kind() == WatcherKind::PollWatcher { | ||
| Box::new(PollWatcher::with_delay(tx,Duration::from_secs(1)).unwrap()) | ||
| } else { | ||
| Box::new(RecommendedWatcher::new(tx).unwrap()) | ||
| }; | ||
|
|
||
|
|
||
| } No newline at end of file |
Member
There was a problem hiding this comment.
It'd be great if we could remove blank lines (i.e. follow rustfmt).
|
|
||
| /// Watcher kind enumeration | ||
| #[derive(Debug,PartialEq,Eq)] | ||
| pub enum WatcherKind { |
Member
There was a problem hiding this comment.
I guess we'll add/remove watchers in the future (actually, kqueue has been added recently) so it should make sense to add the #[non_exhaustive] attribute.
Note that non-boxing would require an enum that matches the CFG chaos of RecommendedWatcher, adding an enum for every possible configurable watcher combination. And otherwise we'll have to add the specific config calls to the trait. Closes #361
Member
Author
|
Should both be addressed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #361