V4 leak fix

[Awfa]

Fixes #287

[0xpr03]

Thanks for the work!

[0xpr03]

Note: I'll do a v4 release once this is merged.

[JohnTitor]

Could we add some tests somehow? I don't think v4 is actively developed but I'd like to avoid the regression by a further patch.

[Awfa]

Could we add some tests somehow? I don't think v4 is actively developed but I'd like to avoid the regression by a further patch.

Hmm - I don't know how we can trigger the specific race using the public interface of ReadDirectoryChangesWatcher - which the test cases use.

[Awfa]

@0xpr03 do you know if those test failures are from just flaky tests? I remember the previous test run didn't have those failures.

[0xpr03]

You can ignore macos tests.

[JohnTitor]

Hmm - I don't know how we can trigger the specific race using the public interface of ReadDirectoryChangesWatcher - which the test cases use.

Hm fair enough, anyway the fix is obvious so I'm fine as-is.

do you know if those test failures are from just flaky tests?

Yeah, currently GHA doesn't support the allow-failure feature.

[Awfa]

Alright - what's the next step to get this PR in? I'm not sure how to rerun the checks.

[JohnTitor]

@0xpr03 Feel free to merge this (and make a new release if needed) if you think we don't need further action here.

[0xpr03]

Yeah I'll have to rebase this later to merge it, according to github. And will do a new release, we've gathered some stuff for the v4. Also I'll make a PR for the 3 liner to v5 and cc @Awfa to make sure it's the correct one.