Update to mio 0.7, remove mio-extras#278
Merged
JohnTitor merged 2 commits intonotify-rs:mainfrom Jan 28, 2021
Merged
Conversation
When INotify::read_buffer finally returns an empty iterator, we break out of the loop. This should allow polling with edge triggering.
Member
|
Hey, thanks for the research and PR. Sadly we will need a solution for #267 first, otherwise this is a regression.. |
Contributor
Author
0xpr03
approved these changes
Jan 26, 2021
Member
0xpr03
left a comment
0xpr03
left a comment
There was a problem hiding this comment.
As folks at tokio also approve the workaround I see no issues anymore with merging.
JohnTitor
approved these changes
Jan 28, 2021
Member
JohnTitor
left a comment
JohnTitor
left a comment
There was a problem hiding this comment.
Awesome, thanks for migrating! Looks great to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR updates mio to version 0.7 and removes mio-extras.
To replace the channel used by mio-extras, we use crossbeam_channel along with a mio::Waker that will be used to wake up the mio event loop whenever we send a message through the crossbeam channel.
Note that mio 0.7 has no level triggering (see tokio-rs/mio#928 ). As such, we need another solution for #267. What I implemented is simply looping over
inotify.read_bufferuntil it returns an empty iterator, at which point we can safely go back to waiting.Fixes #248