Backport some updates and bump version to 4.0.15#232
Merged
JohnTitor merged 4 commits intonotify-rs:try-v4from Jan 2, 2020
Merged
Backport some updates and bump version to 4.0.15#232JohnTitor merged 4 commits intonotify-rs:try-v4from
JohnTitor merged 4 commits intonotify-rs:try-v4from
Conversation
This removes the dependency on kernel32-sys, replacing the kernel32-sys calls with the appropriate winapi calls.
Contributor
Author
|
Hrmm, still failing. I'm not sure exactly what the issue is here. If a maintainer would like to take this over feel free. |
Member
|
Thanks for the PR, I followed your changes, but I think some tests weren't working in the first place. I'll see to that. |
Member
|
Sorry for the delay! I think #236 should make v4 branch green and the failure on macOS is random so we can ignore that. |
Member
|
@JohnTitor do you want to merge/rebase this ? Otherwise ping me if I haven't done this on Monday. |
Member
|
The change looks good, I'd like to see the check suite with rebase. |
Member
|
|
JohnTitor
approved these changes
Dec 25, 2019
Member
JohnTitor
left a comment
JohnTitor
left a comment
There was a problem hiding this comment.
Looks good to me, I'm fine to merge.
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.