fix: error message of SignatureAuthenticityError#269
Merged
4 commits merged intomainfrom Apr 16, 2025
unknown repository
Merged
fix: error message of SignatureAuthenticityError#2694 commits merged intomainfrom unknown repository
SignatureAuthenticityError#2694 commits merged intomainfrom
unknown repository
Conversation
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
ghost
marked this pull request as ready for review
ghost
requested review from
JeyJeyGao,
NiazFK,
gokarnm,
priteshbandi,
rgnote,
shizhMSFT,
toddysm,
vaninrao10 and
yizha1
as code owners
added 2 commits
April 15, 2025 16:51
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Signed-off-by: Patrick Zheng <patrickzheng@microsoft.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #269 +/- ##
=======================================
Coverage 92.26% 92.26%
=======================================
Files 32 32
Lines 2806 2806
=======================================
Hits 2589 2589
Misses 165 165
Partials 52 52 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
yizha1
reviewed
Apr 15, 2025
yizha1
approved these changes
Apr 16, 2025
Contributor
yizha1
left a comment
yizha1
left a comment
There was a problem hiding this comment.
LGTM, but need a PR in notation-go to return more actionable message to the user/caller
ghost
mentioned this pull request
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #266