-
Notifications
You must be signed in to change notification settings - Fork 712
NIP-60: add Wallet Backup Events #1834
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
NIP-60: add Wallet Backup Events #1834
Conversation
to prevent loss of funds if Wallet Event is overwritten with a new `privkey`
c5e5a55 to
ea1e645
Compare
pablof7z
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK. I think this is a very sane addition
|
Why kind 375? My preference would be 7377 (which I am implementing). I think it would be a good idea to keep all the cashu wallet regular events in a 73XX block. I think event kinds <1000 should be reserved for very nostr-generic things versus more specific things, like wallets. Also, are these backup events for kind 7375 only (i.e., proofs) or other events? If just for 7375, the example should show a proof instead. |
Kind 375 was chosen to maintain a consistent numbering theme but I'm not precious about it. It is currently implemented in the Applesauce library, being used in experimental wallets within GitWorkshop and Nostrudel. Since 375 is only utilized for experimental wallets, I don't see any issue with transitioning to 7377. I'll update the PR if @hzrd149 is happy and updates the applesauce.
Its a backup the wallet event 17375 only and not each proof. I dont think backing up each proof at a protocol level is a good idea. |
|
☑️ ndk-wallet (hence Olas) supports kind:375 backups. |
|
ACK: This is a great solution for ensuring safe key rotation too. |
| [ "mint", "https://mint1" ], | ||
| [ "mint", "https://mint2" ] | ||
| ]), | ||
| "tags": [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be even more useful if the backup event had a single character k (key) tag with the corresponding pubkey to the privkey. This would allow REQ filtering with #k to find a wallet backup for a Proof locked to a specific pubkey without having to load, decrypt and check every backup.
Especially important if the user is being prompted for permission each time (eg: via NIP-07 signer)
"tags": [
[ "k", "<hex-pubkey>" ]
]
k: The Nostr hex-format public key corresponding to theprivkeyfield encrypted in the wallet backup.
to prevent loss of funds if Wallet Event is overwritten with a new
privkey