Skip to content

fix: use ditto for notarization archive and add runtime flag to Sparkle #326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jonathancaudill merged 1 commit into from
Feb 28, 2026
Merged

fix: use ditto for notarization archive and add runtime flag to Sparkle #326

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions .github/workflows/macos-notarize.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ jobs:
# Sign the framework version (Versions/B) — do NOT also sign the
# top-level Sparkle.framework symlink; it resolves to the same Versions/B
# directory and double-signing would invalidate the signature.
codesign --force --sign "$SIGNING_IDENTITY" --timestamp "$SPARKLE"
codesign --force --sign "$SIGNING_IDENTITY" --timestamp --options runtime "$SPARKLE"

# Re-sign the main app with entitlements and hardened runtime
codesign --force --sign "$SIGNING_IDENTITY" --timestamp \
Expand All @@ -134,7 +134,10 @@ jobs:
--team-id "$APPLE_TEAM_ID" \
--password "$APPLE_APP_SPECIFIC_PASSWORD"

zip -r Nook.zip "Nook.app"
# ditto preserves macOS symlinks and extended attributes; zip -r does not.
# Broken symlinks in the archive cause "invalid signature" errors because
# the bundle seal references symlink targets, not file copies.
ditto -c -k --keepParent "Nook.app" Nook.zip
SUBMIT_OUTPUT=$(xcrun notarytool submit "Nook.zip" \
--keychain-profile "nook-notary" \
--wait 2>&1)
Expand Down
Loading