Skip to content
Merged

Dev #325

Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions .github/workflows/macos-notarize.yml
Original file line number Diff line number Diff line change
Expand Up @@ -105,17 +105,24 @@ jobs:
codesign --force --sign "$SIGNING_IDENTITY" --timestamp --options runtime \
"$SPARKLE/Updater.app"

# Sign the framework version and top-level
codesign --force --sign "$SIGNING_IDENTITY" --timestamp "$SPARKLE"
# Sign the Sparkle dylib itself before signing the framework bundle
codesign --force --sign "$SIGNING_IDENTITY" --timestamp \
"Nook.app/Contents/Frameworks/Sparkle.framework"
"$SPARKLE/Sparkle"

# Sign the framework version (Versions/B) — do NOT also sign the
# top-level Sparkle.framework symlink; it resolves to the same Versions/B
# directory and double-signing would invalidate the signature.
codesign --force --sign "$SIGNING_IDENTITY" --timestamp "$SPARKLE"

# Re-sign the main app with entitlements and hardened runtime
codesign --force --sign "$SIGNING_IDENTITY" --timestamp \
--options runtime \
--entitlements "$(pwd)/Nook/Nook.entitlements" \
"Nook.app"

- name: Verify signature before notarizing
run: codesign --verify --deep --strict --verbose=2 "Nook.app"

- name: Notarize app
env:
APPLE_ID: ${{ secrets.APPLE_ID }}
Expand Down
21 changes: 21 additions & 0 deletions .gitmodules
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
[submodule "Fuzi"]
path = Fuzi
url = https://github.com/cezheng/Fuzi.git
[submodule "Highlightr"]
path = Highlightr
url = https://github.com/raspu/Highlightr.git
[submodule "LRUCache"]
path = LRUCache
url = https://github.com/nicklockwood/LRUCache.git
[submodule "Motion"]
path = Motion
url = https://github.com/b3ll/Motion.git
[submodule "reeeed"]
path = reeeed
url = https://github.com/nate-parrott/reeeed.git
[submodule "swift-atomics"]
path = swift-atomics
url = https://github.com/apple/swift-atomics.git
[submodule "swift-numerics"]
path = swift-numerics
url = https://github.com/apple/swift-numerics.git
Loading