feat(core): add alignSlides option to keep minimum full slides visi…#8021
Closed
mofman wants to merge 1 commit intonolimits4web:masterfrom
Closed
feat(core): add alignSlides option to keep minimum full slides visi…#8021mofman wants to merge 1 commit intonolimits4web:masterfrom
alignSlides option to keep minimum full slides visi…#8021mofman wants to merge 1 commit intonolimits4web:masterfrom
Conversation
…ble at end - Introduce new boolean param `alignSlides` (default `false`) in core defaults - Trim `snapGrid` so that only snaps leaving ≥ floor(slidesPerView) slides fully visible remain - Preserve original “right-flush” fallback only when `alignSlides` is disabled - Refactor final-snap math into `finalOffset` and `extraGap` for readability
Owner
|
t0ggles-create swiper |
|
Task nolimits4web/SWIPER-171 was created |
Author
|
Any chance of getting this merged reviewed/merged soon? |
Owner
|
Hi, thanks, but was merged kinda manually as a there are still a bunch of use cases + added demo + types |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #4780
Currently it's possible for the swiper to fall out of alignment if a fractional value is set for
slidesPerViewand the user reaches the end of the swiper (as show below). The PR Introduces a new boolean paramalignSlides(defaultfalse) in core defaults and when set totrueensures all sides are always aligned in their original place.alignSlides(defaultfalse) in core defaultssnapGridso that only snaps leaving ≥ floor(slidesPerView) slides fully visible remainalignSlidesis disabled