fix(element): attach container shadow DOM on init#7992
Open
krzksz wants to merge 1 commit intonolimits4web:masterfrom
Open
fix(element): attach container shadow DOM on init#7992krzksz wants to merge 1 commit intonolimits4web:masterfrom
krzksz wants to merge 1 commit intonolimits4web:masterfrom
Conversation
Author
|
@nolimits4web Thank you for looking into the issue. I can see you closed it as "expected behaviour". The fix seems quite simple, but feel free to close this PR if you don't like it. Thanks again! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue I described in #7983.
It moves the shadow DOM attachment for the
SwiperContainerelement from theconstructorto theinitializefunction. This makes sure that the elements stay visible all the time as therenderfunction is triggered synchronously right after.The change is not needed for the
SwiperSlideas it moves its contents immediately anyway.