Webhook registration configuration in Kubernetes

[suyanhj]

Problem

I found that almost all webhooks in the source code are configured by default to be registered to Kubernetes via URL. However, after the service is deployed to the cluster, I believe it should be accessed via the service method instead. I have checked all the official documentation and GitHub examples, but I couldn’t find any related configuration option. So, I would like to ask if there are any plans to add an optional configuration to choose between URL or service for the registration method in the future?

Proposal

Add optional registration configuration for the webhook

Code

def example():
    settings.admission.server = kopf.WebhookServer(addr='0.0.0.0', port=8443, host=conf.listen_host,service=service)

    class WebhookServer(webhacks.WebhookContextManager):
        def __init__(self, *args, **kwargs):
            ...
            self.service = service

        def __call__(self, *args, **kwargs):
            ...
            if self.service:
                client_config = reviews.WebhookClientConfig(service=self.service)
            ...
            client_config = reviews.WebhookClientConfig(url=url)

Additional information

No response

[DeepFlame-JR]

I really agree with it.

[ran-haim]

does it actually work for you accessing via url?
for me it does not find the server (even if I specify service.ns.svc in the url).

[suyanhj]

它真的适用于你通过网址访问吗？
对我来说，它找不到服务器（即使我在网址中指定了service.ns.svc）。

What I show is just a proposal, not a complete code. Because the svc method is not supported for the time being, I chose to write a webhook with fastapi. If it is deployed in the cluster, the built-in webhook of kopf is not supported, and can only be used as a development mode modulation in pycharm.

[suyanhj]

@nolar
Hello [Author],

May I ask if the service registration feature needs to be implemented? I have recently completed the development locally. Would you like me to submit a pull request for merging?