feat(aztec): search for aztec-nargo on top of nargo bin#67
Merged
TomAFrench merged 6 commits intomasterfrom Mar 4, 2024
Merged
feat(aztec): search for aztec-nargo on top of nargo bin#67TomAFrench merged 6 commits intomasterfrom
TomAFrench merged 6 commits intomasterfrom
Conversation
TomAFrench
reviewed
Feb 12, 2024
Member
TomAFrench
left a comment
There was a problem hiding this comment.
There's some issues related to defaulting to aztec-nargo in all cases. We should ensure that we use vanilla nargo in standard noir projects.
Member
|
We should also make sure to handle the edge case where the user has a workspace which contains a mix of contracts and other package types. In this case we should use |
Member
|
Agreed in call that automatic handling of the different versions shouldn't be a requirement for this PR as that would prevent us from moving forwards on this until the next nargo release. Instead we're going to make the status icon clickable to switch between found versions of nargo. |
TomAFrench
approved these changes
Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partialy resolves
LSP to set nargo path based on nargo or aztec-nargo #4233,
Adds
Status Bar item with information about nargo picked.
Indicates with colour and diagnostic message otherwise