fix(ssa): Insert checks for possible OOB array accesses during DIE#9280
Merged
TomAFrench merged 13 commits intotf/optimize-array-access-checksfrom Jul 23, 2025
Merged
Conversation
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
vezenovm
changed the title
Base automatically changed from
mv/array-get-side-effects
to
tf/optimize-array-access-checks
July 22, 2025 19:42
Contributor
Changes to Brillig bytecode sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to number of Brillig opcodes executed
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
Contributor
Changes to circuit sizes
🧾 Summary (10% most significant diffs)
Full diff report 👇
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Execution Time'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: cbc53e1 | Previous: ad16599 | Ratio |
|---|---|---|---|
sha512-100-bytes |
0.104 s |
0.056 s |
1.86 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Test Suite Duration'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: cbc53e1 | Previous: ad16599 | Ratio |
|---|---|---|---|
test_report_AztecProtocol_aztec-packages_noir-projects_noir-protocol-circuits_crates_types |
2 s |
1 s |
2 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @TomAFrench
Contributor
Author
|
Some last arb tests are failing, currently investigating. |
TomAFrench
reviewed
Jul 23, 2025
TomAFrench
reviewed
Jul 23, 2025
TomAFrench
reviewed
Jul 23, 2025
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
TomAFrench
merged commit 81409f2
into
tf/optimize-array-access-checks
96 of 97 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Builds off of #9200. Fixes failures and regressions as a result of #9200.
Alternative to #9232
Summary*
I originally had started just working off of #9232 so that is labelled as the parent as to avoid a long commit history. I'm going to transfer this over so that #9200 is the parent.
Brings back logic introduced in #5691 and deleted in #7995. #5691 was originally created to create parity between ACIR/Brillig without having massive regressions. So I thought it made sense to bring back in this scenario no that we no longer want explicit array OOB checks in SSA for ACIR.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.