Skip to content

chore: carry visibilities in monomorphized AST#8439

Merged
TomAFrench merged 5 commits intomasterfrom
ab/monomorphized-visibility
May 12, 2025
Merged

chore: carry visibilities in monomorphized AST#8439
TomAFrench merged 5 commits intomasterfrom
ab/monomorphized-visibility

Conversation

@asterite
Copy link
Copy Markdown
Collaborator

@asterite asterite commented May 9, 2025

Description

Problem

Resolves #8425

Summary

Additional Context

Documentation

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@asterite asterite changed the title Ab/monomorphized visibility chore: carry visibilities in monomorphized AST May 9, 2025
@asterite asterite requested a review from a team May 12, 2025 11:15
@asterite asterite added this pull request to the merge queue May 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 12, 2025
@TomAFrench TomAFrench added this pull request to the merge queue May 12, 2025
Merged via the queue into master with commit 0e414ec May 12, 2025
116 checks passed
@TomAFrench TomAFrench deleted the ab/monomorphized-visibility branch May 12, 2025 13:45
@aakoshh
Copy link
Copy Markdown
Contributor

aakoshh commented May 12, 2025

Could we change this so that the print looks like what the parser expects?

Currently it prints this:

fn main(call_data(0) a: [(str<0>, str<0>, str<4>, str<4>); 3]

But if I search for call_data in the codebase, I see this:

fn main(
    a: call_data(0) [Field; TX_SIZE],
    b: call_data(1) [Field; APP_CALL_SIZE],
) -> return_data [Field; TX_SIZE] {

It would be great if I could keep copy pasting the printout into Noir files.

@asterite
Copy link
Copy Markdown
Collaborator Author

Ah, good catch. I didn't realize I put it in the wrong location. I'll fix it now.

github-merge-queue bot pushed a commit to AztecProtocol/aztec-packages that referenced this pull request May 13, 2025
Automated pull of nightly from the
[noir](https://github.com/noir-lang/noir) programming language, a
dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
fix: sign extend in signed cast
(noir-lang/noir#8264)
chore(fuzz): Do not use zero length types in the main input output
(noir-lang/noir#8465)
chore: fix visibility issues in test suite
(noir-lang/noir#8454)
chore: blackbox functions for ssa intepreter
(noir-lang/noir#8375)
feat: improve bitshift codegen
(noir-lang/noir#8442)
fix(ssa): Mark mutually recursive simple functions
(noir-lang/noir#8447)
fix: Fix nested trait dispatch with associated types
(noir-lang/noir#8440)
chore: carry visibilities in monomorphized AST
(noir-lang/noir#8439)
chore(tests): Add regression for now passing test
(noir-lang/noir#8441)
chore: use human-readable bytecode in snapshots
(noir-lang/noir#8164)
chore: bump external pinned commits
(noir-lang/noir#8445)
END_COMMIT_OVERRIDE

---------

Co-authored-by: AztecBot <tech@aztecprotocol.com>
Co-authored-by: Tom French <15848336+TomAFrench@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Display data bus visibility in monomorphized AST

3 participants