feat(cli)!: Add `--unstable-features` to gate unstable features by jfecher · Pull Request #7449 · noir-lang/noir

jfecher · 2025-02-19T18:38:47Z

Description

Problem*

Resolves #7423

Summary*

Adds the CLI flag --unstable-features (or -Z) to nargo for all compile sub-commands which accepts a list of unstable features to enable. Without this, usage of these features is now a hard error (previously a warning), making this a breaking change. The list of features to accept can be separated by commas: -Zenums,array-ownership or by specifying the same flag multiple times: -Zenums -Zarray-ownership.

Currently the only unstable features are:

Enums
Array ownership (reserved for future experimentation with & and move semantics for arrays)

Additional Context

I'm using the name "unstable features" to match rust a bit more closely although previously we used "experimental features." I'm open to naming debates since this is a public facing flag we shouldn't change once it is stabilized.

Documentation*

Check one:

No documentation needed.
Documentation included in this PR.
[For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

I have tested the changes locally.
I have formatted the changes with Prettier and/or cargo fmt on default settings.

jfecher · 2025-02-19T18:43:48Z

Hmm looks like CI is broken for some reason because I added a new workspace package. I'll resolve it after lunch but the PR should still be ready for review.

Edit: Completely missed the new crate in git since it was in utils instead of compiler 🤦‍♂️.

compiler/noirc_frontend/src/elaborator/mod.rs

Cargo.toml

utils/cli-args/src/lib.rs

compiler/noirc_frontend/src/hir/def_collector/dc_crate.rs

compiler/noirc_frontend/src/parser/parser/enums.rs

utils/cli-args/src/lib.rs

michaeljklein

LGTM

…rror = ()

* master: (74 commits) feat: optimize out range checks on limiting cases (#7510) chore: clippy fixes (#7505) chore(docs): Supplement docs on `modexp` as a required precompile for Barretenberg's Solidity verifier (#7508) feat(debugger): REPL add breakpoint by sourcecode line (#5204) fix: issue duplicate error on impl function without self (#7490) feat(experimental): Support struct constructors in match patterns (#7489) feat: use resolved type instead of needing Constructor.struct_type (#7500) feat: better error message when keyword is found instead of type in p… (#7501) chore: bump external pinned commits (#7497) feat(experimental): Add invalid pattern syntax error (#7487) fix(performance): Accurately mark safe constant indices for arrays of complex types (#7491) fix(experimental): Allow shadowing in match patterns (#7484) chore: regression test #7195 (#7233) chore(docs): Section on `noir-profiler execution-opcodes` (#7480) chore: improve proptesting of 128bit values in `noirc_abi` (#7485) chore(profiler): Use brillig names for outputted flamegraphs (#7470) chore(docs): Profiler images reference (#7481) fix: don't use dummy location when inserting debug code (#7482) feat(cli)!: Add `--unstable-features` to gate unstable features (#7449) feat: Sync from aztec-packages (#7474) ...

feat: let all compiler errors carry a Location instead of a Span (noir-lang/noir#7486) chore: Increaes base64's allotted time (noir-lang/noir#7521) fix: don't crash on broken impl syntax (noir-lang/noir#7512) feat: optimize out range checks on limiting cases (noir-lang/noir#7510) chore: clippy fixes (noir-lang/noir#7505) chore(docs): Supplement docs on `modexp` as a required precompile for Barretenberg's Solidity verifier (noir-lang/noir#7508) feat(debugger): REPL add breakpoint by sourcecode line (noir-lang/noir#5204) fix: issue duplicate error on impl function without self (noir-lang/noir#7490) feat(experimental): Support struct constructors in match patterns (noir-lang/noir#7489) feat: use resolved type instead of needing Constructor.struct_type (noir-lang/noir#7500) feat: better error message when keyword is found instead of type in p… (noir-lang/noir#7501) chore: bump external pinned commits (noir-lang/noir#7497) feat(experimental): Add invalid pattern syntax error (noir-lang/noir#7487) fix(performance): Accurately mark safe constant indices for arrays of complex types (noir-lang/noir#7491) fix(experimental): Allow shadowing in match patterns (noir-lang/noir#7484) chore: regression test #7195 (noir-lang/noir#7233) chore(docs): Section on `noir-profiler execution-opcodes` (noir-lang/noir#7480) chore: improve proptesting of 128bit values in `noirc_abi` (noir-lang/noir#7485) chore(profiler): Use brillig names for outputted flamegraphs (noir-lang/noir#7470) chore(docs): Profiler images reference (noir-lang/noir#7481) fix: don't use dummy location when inserting debug code (noir-lang/noir#7482) feat(cli)!: Add `--unstable-features` to gate unstable features (noir-lang/noir#7449)

Automated pull of development from the [noir](https://github.com/noir-lang/noir) programming language, a dependency of Aztec. BEGIN_COMMIT_OVERRIDE chore: bump external pinned commits (noir-lang/noir#7515) feat: let all compiler errors carry a Location instead of a Span (noir-lang/noir#7486) chore: Increaes base64's allotted time (noir-lang/noir#7521) fix: don't crash on broken impl syntax (noir-lang/noir#7512) feat: optimize out range checks on limiting cases (noir-lang/noir#7510) chore: clippy fixes (noir-lang/noir#7505) chore(docs): Supplement docs on `modexp` as a required precompile for Barretenberg's Solidity verifier (noir-lang/noir#7508) feat(debugger): REPL add breakpoint by sourcecode line (noir-lang/noir#5204) fix: issue duplicate error on impl function without self (noir-lang/noir#7490) feat(experimental): Support struct constructors in match patterns (noir-lang/noir#7489) feat: use resolved type instead of needing Constructor.struct_type (noir-lang/noir#7500) feat: better error message when keyword is found instead of type in p… (noir-lang/noir#7501) chore: bump external pinned commits (noir-lang/noir#7497) feat(experimental): Add invalid pattern syntax error (noir-lang/noir#7487) fix(performance): Accurately mark safe constant indices for arrays of complex types (noir-lang/noir#7491) fix(experimental): Allow shadowing in match patterns (noir-lang/noir#7484) chore: regression test #7195 (noir-lang/noir#7233) chore(docs): Section on `noir-profiler execution-opcodes` (noir-lang/noir#7480) chore: improve proptesting of 128bit values in `noirc_abi` (noir-lang/noir#7485) chore(profiler): Use brillig names for outputted flamegraphs (noir-lang/noir#7470) chore(docs): Profiler images reference (noir-lang/noir#7481) fix: don't use dummy location when inserting debug code (noir-lang/noir#7482) feat(cli)!: Add `--unstable-features` to gate unstable features (noir-lang/noir#7449) END_COMMIT_OVERRIDE --------- Co-authored-by: guipublic <[email protected]> Co-authored-by: guipublic <[email protected]>

jfecher added 4 commits February 18, 2025 15:09

Add -Z CLI flag

3e103a3

Derive EnumParser instead

64c3b71

Move flags from the parser to the elaborator

452e8aa

Separate args with ,

5c5965a

jfecher requested a review from a team February 19, 2025 18:38

jfecher changed the title ~~feat(cli)!: Add --unstable-features item1,item2,item3,.. or -Zfeature to gate unstable features~~ feat(cli)!: Add --unstable-features to gate unstable features Feb 19, 2025

jfecher added 2 commits February 19, 2025 12:41

Clippy

0fd46f9

Merge branch 'master' into jf/unstable-features

e5fe1cd

aakoshh reviewed Feb 19, 2025

View reviewed changes

compiler/noirc_frontend/src/elaborator/mod.rs Outdated Show resolved Hide resolved

vezenovm reviewed Feb 19, 2025

View reviewed changes

Cargo.toml Outdated Show resolved Hide resolved

jfecher added 2 commits February 19, 2025 14:18

Add missed utils crate

0272886

Rename cli_options -> options

6e0ccf9

aakoshh reviewed Feb 19, 2025

View reviewed changes

utils/cli-args/src/lib.rs Outdated Show resolved Hide resolved

michaeljklein suggested changes Feb 19, 2025

View reviewed changes

compiler/noirc_frontend/src/hir/def_collector/dc_crate.rs Outdated Show resolved Hide resolved

compiler/noirc_frontend/src/parser/parser/enums.rs Outdated Show resolved Hide resolved

utils/cli-args/src/lib.rs Outdated Show resolved Hide resolved

jfecher added 3 commits February 19, 2025 15:10

Warning -> error

c58d575

Add test

06a607a

Split test into enum & match cases

0bc7c05

michaeljklein approved these changes Feb 19, 2025

View reviewed changes

Jake Fecher and others added 6 commits February 20, 2025 07:35

Remove lifetimes

d96df5e

Enable enums for integration tests

05edf22

Move code out of cli-args

5aef8e4

Finish removing cli-args crate, turns out clap errors when FromStr::E…

ca1e0dc

…rror = ()

Fix import

17b55a7

Merge branch 'master' into jf/unstable-features

0d3656e

jfecher enabled auto-merge February 20, 2025 20:23

jfecher added this pull request to the merge queue Feb 21, 2025

Merged via the queue into master with commit fd213f6 Feb 21, 2025
102 checks passed

jfecher deleted the jf/unstable-features branch February 21, 2025 15:45

noirwhal mentioned this pull request Feb 20, 2025

chore: Release Noir(1.0.0-beta.4) #7475

Merged

AztecBot mentioned this pull request Feb 26, 2025

feat: Sync from noir AztecProtocol/aztec-packages#12279

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(cli)!: Add `--unstable-features` to gate unstable features#7449

feat(cli)!: Add `--unstable-features` to gate unstable features#7449
jfecher merged 17 commits intomasterfrom
jf/unstable-features

jfecher commented Feb 19, 2025

Uh oh!

jfecher commented Feb 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaeljklein left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

jfecher commented Feb 19, 2025

Description

Problem*

Summary*

Additional Context

Documentation*

PR Checklist*

Uh oh!

jfecher commented Feb 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

michaeljklein left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jfecher commented Feb 19, 2025 •

edited

Loading