fix: always return an array of u8s when simplifying Intrinsic::ToRadix calls#6663
Merged
TomAFrench merged 3 commits intomasterfrom Dec 2, 2024
Merged
fix: always return an array of u8s when simplifying Intrinsic::ToRadix calls#6663TomAFrench merged 3 commits intomasterfrom
u8s when simplifying Intrinsic::ToRadix calls#6663TomAFrench merged 3 commits intomasterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves #6662
Summary*
If someone attempts to do a decomposition into radices other than 2 or 256 then we'll end up returning the incorrect type. This PR solves this issue.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.