Skip to content

fix: always return an array of u8s when simplifying Intrinsic::ToRadix calls#6663

Merged
TomAFrench merged 3 commits intomasterfrom
tf/fix-simplified-to-radix
Dec 2, 2024
Merged

fix: always return an array of u8s when simplifying Intrinsic::ToRadix calls#6663
TomAFrench merged 3 commits intomasterfrom
tf/fix-simplified-to-radix

Conversation

@TomAFrench
Copy link
Copy Markdown
Member

@TomAFrench TomAFrench commented Nov 29, 2024

Description

Problem*

Resolves #6662

Summary*

If someone attempts to do a decomposition into radices other than 2 or 256 then we'll end up returning the incorrect type. This PR solves this issue.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SSA simplifications are returning incorrect types

2 participants