feat(perf): Remove redundant inc rc without instructions between#6183
Merged
feat(perf): Remove redundant inc rc without instructions between#6183
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Part of general effort to reduce Brillig bytecode sizes.
Summary*
We often have patterns like such (example from
brillig_rc_regression_6123):It is usually due to each impl method that mutably borrows self placing inc RCs on the internal arrays of the struct for which it is implementing the method. Without any instructions in between these
inc_rcinstructions, we can safely collapse the inc_rcs into a single one.The SSA was
brillig_rc_regression_6123now looks like such:This PR does a slight refactor as the
track_inc_rcs_to_removewas starting to take a lot of parameters. I made a newRcTrackerstruct. Its state is simply updated per instruction as previously and then the instructions it marks for removal are including at the end of performing DIE on a block.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.