Skip to content

feat: swap endianness in-place in keccak implementation#6128

Merged
TomAFrench merged 6 commits intomasterfrom
tf/avoid-temporary-array-in-keccak
Sep 23, 2024
Merged

feat: swap endianness in-place in keccak implementation#6128
TomAFrench merged 6 commits intomasterfrom
tf/avoid-temporary-array-in-keccak

Conversation

@TomAFrench
Copy link
Copy Markdown
Member

Description

Problem*

Resolves

Summary*

This PR removes the temp array created when swapping the endianness of the block_bytes array and just swaps the values in place. This removes some unnecessary reads/writes from brillig.

Additional Context

Documentation*

Check one:

  • No documentation needed.
  • Documentation included in this PR.
  • [For Experimental Features] Documentation to be submitted in a separate PR.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants