Skip to content

fix: (LSP) only add cached files relevant to workspace #5775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asterite merged 3 commits into from
Aug 20, 2024
Merged

fix: (LSP) only add cached files relevant to workspace #5775

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27ce45c
Fix: (LSP) only add cached files relevant to workspace
asterite Aug 20, 2024
3a5d04b
Allow overriding a path's source code, and use that in LSP
asterite Aug 20, 2024
7e6e25b
clippy
asterite Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions tooling/lsp/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -387,11 +387,19 @@ pub fn insert_all_files_for_workspace_into_file_manager(
workspace: &Workspace,
file_manager: &mut FileManager,
) {
let root_dir: String = workspace.root_dir.as_os_str().to_string_lossy().into();

// First add files we cached: these have the source code of files that are modified
// but not saved to disk yet, and we want to make sure all LSP features work well
// according to these unsaved buffers, not what's saved on disk.
for (path, source) in &state.input_files {
let path = path.strip_prefix("file://").unwrap();

// Only add files relevant to the workspace
if !path.starts_with(&root_dir) {
continue;
}

file_manager.add_file_with_source_canonical_path(Path::new(path), source.clone());
}

Expand Down