-
Notifications
You must be signed in to change notification settings - Fork 381
feat: add some Module comptime functions
#5684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
5e5d315
Add `Quoted::as_module`
asterite 4c9c5fe
Add `Module::is_contract`
asterite 3734fce
Add `Module::functions`
asterite 3cfa3fc
Add `Module::name`
asterite 3648671
Add `FunctionDefinition::name`
asterite 5f9996e
clippy
asterite d4fe606
Apply suggestions from code review
asterite d77e306
Fixes after suggestions
asterite 901dc88
Easier way to re-export some parser functions
asterite File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| impl Module { | ||
| #[builtin(module_is_contract)] | ||
| fn is_contract(self) -> bool {} | ||
|
|
||
| #[builtin(module_functions)] | ||
| fn functions(self) -> [FunctionDefinition] {} | ||
|
|
||
| #[builtin(module_name)] | ||
| fn name(self) -> Quoted {} | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
test_programs/compile_success_empty/comptime_module/Nargo.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| [package] | ||
| name = "comptime_module" | ||
| type = "bin" | ||
| authors = [""] | ||
| compiler_version = ">=0.31.0" | ||
|
|
||
| [dependencies] |
26 changes: 26 additions & 0 deletions
26
test_programs/compile_success_empty/comptime_module/src/main.nr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| mod foo { | ||
| fn x() {} | ||
| fn y() {} | ||
| } | ||
|
|
||
| contract bar {} | ||
|
|
||
| fn main() { | ||
| comptime | ||
| { | ||
| // Check Module::is_contract | ||
| let foo = quote { foo }.as_module().unwrap(); | ||
| assert(!foo.is_contract()); | ||
|
|
||
| let bar = quote { bar }.as_module().unwrap(); | ||
| assert(bar.is_contract()); | ||
|
|
||
| // Check Module::functions | ||
| assert_eq(foo.functions().len(), 2); | ||
| assert_eq(bar.functions().len(), 0); | ||
|
|
||
| // Check Module::name | ||
| assert_eq(foo.name(), quote { foo }); | ||
| assert_eq(bar.name(), quote { bar }); | ||
| } | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.