feat: add comptime support for modulus_* compiler builtins#5530
Merged
TomAFrench merged 7 commits intomasterfrom Jul 17, 2024
Merged
feat: add comptime support for modulus_* compiler builtins#5530TomAFrench merged 7 commits intomasterfrom
modulus_* compiler builtins#5530TomAFrench merged 7 commits intomasterfrom
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR changes the function
std::compat::is_bn254to run in acomptimecontext. To do this I've had to implement a few compiler builtins within the interpreter.I've had to mangle
std::compat::is_bn254a bit to get around restrictions on when a function can be called in acomptimecontext however.This works around around the loop unrolling issue experienced in #4535.
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.