Skip to content

chore: address TODO in compat.nr #5339

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfecher merged 1 commit into from
Jun 26, 2024
Merged

chore: address TODO in compat.nr #5339

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 2 additions & 13 deletions noir_stdlib/src/compat.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,18 +1,7 @@
global BN254_MODULUS_BE_BYTES: [u8; 32] = [
global BN254_MODULUS_BE_BYTES: [u8] = &[
48, 100, 78, 114, 225, 49, 160, 41, 184, 80, 69, 182, 129, 129, 88, 93, 40, 51, 232, 72, 121, 185, 112, 145, 67, 225, 245, 147, 240, 0, 0, 1
];

pub fn is_bn254() -> bool {
// TODO: refactor this once https://github.com/noir-lang/noir/issues/5245 is resolved.
let modulus_bytes = crate::field::modulus_be_bytes();
if modulus_bytes.len() == 32 {
let mut modulus_bytes_array: [u8; 32] = [0; 32];
for i in 0..32 {
modulus_bytes_array[i] = modulus_bytes[i];
}

modulus_bytes_array == BN254_MODULUS_BE_BYTES
} else {
false
}
crate::field::modulus_be_bytes() == BN254_MODULUS_BE_BYTES
}