Skip to content

fix: fix usage of #[abi(tag)] attribute with elaborator #5298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 2 commits into from
Jun 25, 2024
Merged

fix: fix usage of #[abi(tag)] attribute with elaborator #5298

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf7fb09
fix: fix usage of `#[abi(tag)] attribute with elaborator
TomAFrench Jun 20, 2024
d9412a3
Update test_programs/compile_success_contract/abi_attribute/src/main.nr
TomAFrench Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion compiler/noirc_frontend/src/elaborator/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1190,7 +1190,7 @@ impl<'context> Elaborator<'context> {
self.current_item = Some(DependencyId::Global(global_id));
let let_stmt = global.stmt_def;

if !self.in_contract
if !self.module_id().module(self.def_maps).is_contract
&& let_stmt.attributes.iter().any(|attr| matches!(attr, SecondaryAttribute::Abi(_)))
{
let span = let_stmt.pattern.span();
Expand Down
6 changes: 6 additions & 0 deletions test_programs/compile_success_contract/abi_attribute/Nargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
[package]
name = "abi_attribute"
type = "contract"
authors = [""]

[dependencies]
4 changes: 4 additions & 0 deletions test_programs/compile_success_contract/abi_attribute/src/main.nr
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
contract Foo {
#[abi(foo)]
global foo: Field = 42;
}