Skip to content

fix: Update noir-gates-diff commit to use master reference report #4891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vezenovm merged 23 commits into from
Apr 23, 2024
Merged

fix: Update noir-gates-diff commit to use master reference report #4891

Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
d0bdce4
test adding gates to 1_mul
vezenovm Apr 22, 2024
43919f2
Merge branch 'master' into mv/test-gates-diff
vezenovm Apr 22, 2024
1253978
fix 1_mul cause x is mutable
vezenovm Apr 22, 2024
0ea6893
Merge remote-tracking branch 'origin/mv/test-gates-diff' into mv/test…
vezenovm Apr 22, 2024
3e9f4bf
update commit
vezenovm Apr 22, 2024
affee0c
update commit to force report
vezenovm Apr 22, 2024
f83f269
pdate commit
vezenovm Apr 22, 2024
c348fea
update commit to use debug info
vezenovm Apr 22, 2024
ec67f37
update commit
vezenovm Apr 23, 2024
a12475d
print report as json
vezenovm Apr 23, 2024
e4bb1f0
change commit
vezenovm Apr 23, 2024
78d2ad4
switch to package_name
vezenovm Apr 23, 2024
882f0a7
update commit after actually publishing
vezenovm Apr 23, 2024
ca873a7
update commit
vezenovm Apr 23, 2024
5ff2e60
remove clone on info cmd structures
vezenovm Apr 23, 2024
11e7dad
update commit
vezenovm Apr 23, 2024
432815c
Merge branch 'master' into mv/test-gates-diff
vezenovm Apr 23, 2024
8989e46
use commit referencing https://github.com/vezenovm/noir-gates-diff/pu…
vezenovm Apr 23, 2024
5e70370
revert 1_mul addition
vezenovm Apr 23, 2024
14d449a
reevert 1_mul additions
vezenovm Apr 23, 2024
3dcb563
Merge remote-tracking branch 'origin/mv/test-gates-diff' into mv/test…
vezenovm Apr 23, 2024
6f7fed3
Merge branch 'mv/test-gates-diff' into mv/fix-gates-diff-ref-report
vezenovm Apr 23, 2024
cca09d0
merge conflcits w/ master and reference merged PR #2 from vezenovm/no…
vezenovm Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gates_report.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ jobs:

- name: Compare gates reports
id: gates_diff
uses: vezenovm/noir-gates-diff@45e9c9a21deb236fa7f38138b42b33ddaf7c0985
uses: vezenovm/noir-gates-diff@acf12797860f237117e15c0d6e08d64253af52b6
with:
report: gates_report.json
summaryQuantile: 0.9 # only display the 10% most significant circuit size diffs in the summary (defaults to 20%)
Expand Down