feat: Optimize array sets in if conditions (alternate version)

compiler/noirc_evaluator/src/ssa/acir_gen/mod.rs

@@ -1218,11 +1218,14 @@ impl<'a> Context<'a> {
         var_index: &mut AcirVar,
     ) -> Result<AcirValue, RuntimeError> {
         let one = self.acir_context.add_constant(FieldElement::one());
-        let result = match ssa_type.clone() {
+        match ssa_type.clone() {
             Type::Numeric(numeric_type) => {
                 // Read the value from the array at the specified index
                 let read = self.acir_context.read_from_memory(block_id, var_index)?;
 
+                // Increment the var_index in case of a nested array
+                *var_index = self.acir_context.add_var(*var_index, one)?;
+
                 let typ = AcirType::NumericType(numeric_type);
                 Ok(AcirValue::Var(read, typ))
             }
@@ -1236,11 +1239,7 @@ impl<'a> Context<'a> {
                 Ok(AcirValue::Array(values))
             }
             _ => unreachable!("ICE: Expected an array or numeric but got {ssa_type:?}"),
-        };
-
-        // Increment the var_index in case of a nested array
-        *var_index = self.acir_context.add_var(*var_index, one)?;
-        result
+        }
     }
 
     /// If `mutate_array` is:

test_programs/execution_success/nested_array_dynamic_simple/Nargo.toml

@@ -0,0 +1,7 @@
+[package]
+name = "nested_array_dynamic_simple"
+type = "bin"
+authors = [""]
+compiler_version = ">=0.28.0"
+
+[dependencies]

test_programs/execution_success/nested_array_dynamic_simple/Prover.toml

@@ -0,0 +1 @@
+x = "3"

test_programs/execution_success/nested_array_dynamic_simple/src/main.nr

@@ -0,0 +1,9 @@
+fn main(x: Field) {
+    // x = 3
+    let array: [[(Field, [Field; 1], [Field; 1]); 1]; 1] = [[(1, [2], [3])]];
+
+    let fetched_value = array[x - 3];
+    assert(fetched_value[0].0 == 1);
+    assert(fetched_value[0].1[0] == 2);
+    assert(fetched_value[0].2[0] == 3);
+}