Skip to content

fix(ssa): Do not use get_value_max_num_bits when we want pure type information #4700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jfecher merged 2 commits into from
Apr 3, 2024
Merged

fix(ssa): Do not use get_value_max_num_bits when we want pure type information #4700

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
133c1a6
switch to bit_size from get_value_max_num_bits
vezenovm Apr 2, 2024
a144ef1
chore: remove optimisation
TomAFrench Apr 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions compiler/noirc_evaluator/src/ssa/ir/instruction/binary.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,21 +171,6 @@ impl Binary {
return SimplifyResult::SimplifiedTo(one);
}

if operand_type.is_unsigned() {
// If we're comparing a variable against a constant value which lies outside of the range of
// values which the variable's type can take, we can assume that the equality will be false.
let constant = lhs.or(rhs);
let non_constant = if lhs.is_some() { self.rhs } else { self.lhs };
if let Some(constant) = constant {
let max_possible_value =
2u128.pow(dfg.get_value_max_num_bits(non_constant)) - 1;
if constant > max_possible_value.into() {
let zero = dfg.make_constant(FieldElement::zero(), Type::bool());
return SimplifyResult::SimplifiedTo(zero);
}
}
}

if operand_type == Type::bool() {
// Simplify forms of `(boolean == true)` into `boolean`
if lhs_is_one {
Expand Down