Conversation
71bbc59 to
517077b
Compare
|
Can we just quietly not include |
|
Interesting, I personally feel the opposite and feel that usage of |
|
There's also the fact that we're probably going to end up with an implementation of this trait out in the wild anyway. |
# Description ## Problem\* Supercedes #4148 ## Summary\* This PR adds a definition of `From` and `Into` traits into the Noir prelude. I've provided implementations for the primitive types along with the trivial general implementations of the traits. ## Additional Context ## Documentation\* Check one: - [ ] No documentation needed. - [ ] Documentation included in this PR. - [x] **[Exceptional Case]** Documentation to be submitted in a separate PR. Will document once codegen is up. # PR Checklist\* - [x] I have tested the changes locally. - [x] I have formatted the changes with [Prettier](https://prettier.io/) and/or `cargo fmt` on default settings.
Description
Problem*
Resolves
Summary*
I'm experimenting with implementing
FromandIntonow as generic traits are being built out.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.