Skip to content

feat: simplify chains of casts to be all in terms of the original ValueId #3984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomAFrench merged 5 commits into from
Jan 11, 2024
Merged

feat: simplify chains of casts to be all in terms of the original ValueId #3984

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
58b3c0c
feat: simplify chains of casts to be all in terms of the original `Va…
TomAFrench Jan 8, 2024
49cb5c9
Merge branch 'master' into tf/remove-cast-chains
kevaundray Jan 9, 2024
516289f
Merge branch 'master' into tf/remove-cast-chains
TomAFrench Jan 9, 2024
376d3ac
Merge branch 'master' into tf/remove-cast-chains
TomAFrench Jan 9, 2024
06210b8
Merge branch 'master' into tf/remove-cast-chains
TomAFrench Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions compiler/noirc_evaluator/src/ssa/ir/instruction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,6 +546,14 @@ impl Instruction {
/// that value is returned. Otherwise None is returned.
fn simplify_cast(value: ValueId, dst_typ: &Type, dfg: &mut DataFlowGraph) -> SimplifyResult {
use SimplifyResult::*;
let value = dfg.resolve(value);

if let Value::Instruction { instruction, .. } = &dfg[value] {
if let Instruction::Cast(original_value, _) = &dfg[*instruction] {
return SimplifiedToInstruction(Instruction::Cast(*original_value, dst_typ.clone()));
}
}

if let Some(constant) = dfg.get_numeric_constant(value) {
let src_typ = dfg.type_of_value(value);
match (src_typ, dst_typ) {
Expand Down