chore: updating the noirjs tutorial to match stable + some other improvements#3929
Merged
signorecello merged 5 commits intomasterfrom Jan 5, 2024
Merged
chore: updating the noirjs tutorial to match stable + some other improvements#3929signorecello merged 5 commits intomasterfrom
signorecello merged 5 commits intomasterfrom
Conversation
github-actions
bot
added
the
documentation
Contributor
|
🚀 Deployed on https://6596bb9e4668bf08cf485d56--noir-docs.netlify.app |
critesjosh
reviewed
Jan 3, 2024
Contributor
critesjosh
left a comment
critesjosh
left a comment
There was a problem hiding this comment.
Looks good, working smooth for me! Just some minor nits
TomAFrench
changed the title
critesjosh
approved these changes
Jan 5, 2024
TomAFrench
added a commit
that referenced
this pull request
Jan 8, 2024
* master: chore: Stop cloning `FuncMeta` (#3968) feat: add MVP `nargo export` command (#3870) chore: clippy and general cleanup of debugger (#3957) chore: updating the noirjs tutorial to match stable + some other improvements (#3929) chore: add `insert_range_check` method to `FunctionBuilder` (#3959) chore: remove usage of term "preprocessed" in favour of "artifact" (#3939)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the NoirJS tutorial and adds some other improvements.
Problem*
It wasn't too critical, but the
NoirJStutorial was a bit outdated.Summary*
I picked on this task on my way towards documenting oracles. Summary of changes:
yarnoption for the sake of simplicity (inspired by ignore options and alternatives in Diátaxis framework)rollup-copyand makeshift vite plugin in favour of a painlesssetupphase to init thewasms instead, this way we can usenpm create viteand basically forget vite.