chore: moving ordering to category jsons and frontmatters#3777
Merged
signorecello merged 2 commits intomasterfrom Dec 13, 2023
Merged
chore: moving ordering to category jsons and frontmatters#3777signorecello merged 2 commits intomasterfrom
signorecello merged 2 commits intomasterfrom
Conversation
github-actions
bot
added
the
documentation
TomAFrench
approved these changes
Dec 12, 2023
Member
TomAFrench
left a comment
TomAFrench
left a comment
There was a problem hiding this comment.
Gonna trust that all the links have been updated (does docusaurus check this automatically?)
Contributor
Author
|
@Savio-Sou my friend in PR reviews (and more) here's the PR to reorder stuff without prefixes as suggested in the docusaurus docs for v3 |
Contributor
Author
|
Yes @TomAFrench it will fail to build if there are dead links 👍 |
Contributor
|
🚀 Deployed on https://657876a3f9d08e7763ad8ca6--noir-docs.netlify.app |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
After clicking on 'Try it now!', the following error occurs: |
Contributor
Author
|
glad you were the only one actually clicking the preview haha I'll have a look, thanks Kev |
Contributor
Thats not me ser :) |
Contributor
Author
|
oh damn your avatars are too similar 😄 fixed that regression @f01dab1e , somehow introduced in #3711 . Still waiting for the next docusaurus to bump webpack version, to avoid this stupid workaround |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
5 tasks
TomAFrench
added a commit
that referenced
this pull request
Dec 14, 2023
* master: (25 commits) chore!: Make file manager read-only to the compiler (#3760) feat: Add some traits to the stdlib (#3796) fix: Stop issuing unused variable warnings for variables in trait definitions (#3797) fix(lsp): package resolution on save (#3794) chore: clippy fix (#3793) feat: Remove experimental feature warning for traits (#3783) fix: Allow trait method references from the trait name (#3774) chore: adds a new option only-acir (#3683) feat(lsp): add goto definition for structs (#3718) chore: disable code lens feature of lsp (#3789) chore: moving ordering to category jsons and frontmatters (#3777) chore(ci): use `actions/setup-node` for caching yarn dependencies (#2730) fix: remove `noirc_driver/aztec` feature flag in docker (#3784) chore: remove aztec compile time feature flag (#3596) chore: move debugger tests in submodule (#3780) feat: simplify explicit equality assertions to assert equality directly (#3708) fix(ssa): Handle array arguments to side effectual constrain statements (#3740) feat: add `prelude.nr` (#3693) chore: removing old docs (#3778) feat: avoid overflow checks on boolean multiplication (#3745) ...
TomAFrench
added a commit
that referenced
this pull request
Dec 14, 2023
* master: (148 commits) feat: add support for writing tracing debug info to file (#3790) chore: clippy fix (#3803) chore(ci): enforce timeouts on build and test workflows (#3804) chore!: remove unused `source-resolver` package (#3791) chore!: Make file manager read-only to the compiler (#3760) feat: Add some traits to the stdlib (#3796) fix: Stop issuing unused variable warnings for variables in trait definitions (#3797) fix(lsp): package resolution on save (#3794) chore: clippy fix (#3793) feat: Remove experimental feature warning for traits (#3783) fix: Allow trait method references from the trait name (#3774) chore: adds a new option only-acir (#3683) feat(lsp): add goto definition for structs (#3718) chore: disable code lens feature of lsp (#3789) chore: moving ordering to category jsons and frontmatters (#3777) chore(ci): use `actions/setup-node` for caching yarn dependencies (#2730) fix: remove `noirc_driver/aztec` feature flag in docker (#3784) chore: remove aztec compile time feature flag (#3596) chore: move debugger tests in submodule (#3780) feat: simplify explicit equality assertions to assert equality directly (#3708) ...
AztecBot
pushed a commit
that referenced
this pull request
Jan 2, 2024
sirasistant
pushed a commit
that referenced
this pull request
Jan 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This big PR does a simple thing: It makes pages ordering respect metadata instead of filenames
Problem*
A naive approach supported over the years at docusaurus was to simply have files prefixed with 00, 01, 02, which were removed automatically by docusaurus.
This makes docs a bit harder to maintain if for some reason you decide to move pages around, as it breaks all the links.
Summary*
sidebar_positionproperty in frontmatter, to order them_category_.jsonfiles to order folderssidebars.json