fix(docs): trigger update-docs workflow when the release-please PR gets merged and not on every merge to master#3677
Merged
kevaundray merged 1 commit intomasterfrom Dec 2, 2023
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently we are triggering the update-docs workflow when there is a change on the release-please PR branch, this is okay for workflows like update-lockfile. However, it doesn't work for update-docs because it uses
needs.release-please.outputs.release-tag-namewhich depends on the release-please tag which we get after we have merged the release-please PR into master.See here for example where update lockfile is ran on master.
Problem*
Resolves
Summary*
Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.