chore: remove unnecessary conversions from add_constant#3651
Merged
TomAFrench merged 1 commit intomasterfrom Nov 30, 2023
Merged
chore: remove unnecessary conversions from add_constant#3651TomAFrench merged 1 commit intomasterfrom
add_constant#3651TomAFrench merged 1 commit intomasterfrom
Conversation
jfecher
approved these changes
Nov 30, 2023
TomAFrench
added a commit
that referenced
this pull request
Dec 1, 2023
* master: (124 commits) chore: add env var for test updates in nargo_fmt (#3638) chore: remove unnecessary conversions from `add_constant` (#3651) feat: Complex slice inputs for dynamic slice builtins (#3617) feat: Add `FieldElement::from<usize>` implementation (#3647) chore: fix relative paths in reease please (#3646) chore: add integration test for verifying a recursive proof onchain (#3167) chore: adding docs to release please (#3571) chore(ci): Fix publishing of ACVM crates (#3645) chore(docs): address visibility issues in docs (#3643) chore: type formatting (#3618) fix: Restrict fill_internal_slices pass to acir functions (#3634) chore(docs): docs for v0.19.4 (#3601) feat: aztec-packages (#3626) chore: Move tests to the correct root (#3633) feat: Implement integer printing (#3577) fix: corrected the formatting of error message parameters in index out of bounds error (#3630) chore: Update ACIR artifacts (#3619) chore(debugger): Run debugger REPL in thread (#3611) chore: remove deprecated method (#3625) feat: Implement raw string literals (#3556) ...
TomAFrench
added a commit
that referenced
this pull request
Dec 1, 2023
* master: (28 commits) feat: reuse witnesses more when interacting with memory (#3658) chore(ci): stop committing new acir artifacts (#3654) chore: add env var for test updates in nargo_fmt (#3638) chore: remove unnecessary conversions from `add_constant` (#3651) feat: Complex slice inputs for dynamic slice builtins (#3617) feat: Add `FieldElement::from<usize>` implementation (#3647) chore: fix relative paths in reease please (#3646) chore: add integration test for verifying a recursive proof onchain (#3167) chore: adding docs to release please (#3571) chore(ci): Fix publishing of ACVM crates (#3645) chore(docs): address visibility issues in docs (#3643) chore: type formatting (#3618) fix: Restrict fill_internal_slices pass to acir functions (#3634) chore(docs): docs for v0.19.4 (#3601) feat: aztec-packages (#3626) chore: Move tests to the correct root (#3633) feat: Implement integer printing (#3577) fix: corrected the formatting of error message parameters in index out of bounds error (#3630) chore: Update ACIR artifacts (#3619) chore(debugger): Run debugger REPL in thread (#3611) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
This PR updates new code from #3617 to use the new form of
add_constantadded in #3647.Additional Context
Documentation*
Check one:
PR Checklist*
cargo fmton default settings.