Skip to content

chore: enhance code formatting for If expressions#3246

Merged
jfecher merged 10 commits into
masterfrom
unknown repository
Oct 23, 2023
Merged

chore: enhance code formatting for If expressions#3246
jfecher merged 10 commits into
masterfrom
unknown repository

Conversation

@ghost

@ghost ghost commented Oct 23, 2023

Copy link
Copy Markdown

Description

PR Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@ghost ghost marked this pull request as ready for review October 23, 2023 15:54
@ghost

ghost commented Oct 23, 2023

Copy link
Copy Markdown
Author

@jfecher please review this, if you can

@jfecher jfecher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jfecher jfecher added this pull request to the merge queue Oct 23, 2023
Merged via the queue into noir-lang:master with commit 247b7ce Oct 23, 2023
TomAFrench added a commit that referenced this pull request Oct 24, 2023
* master:
  chore(docs): Rearrange NoirJS section (#3260)
  chore(docs): Document `nargo fmt` (#3262)
  feat(debugger): Print limited source code context (#3217)
  fix: recompile artefacts from a different noir version (#3248)
  chore: Update ACIR artifacts (#3263)
  fix: Show println output before an error occurs in `nargo execute` (#3211)
  chore(docs): document info codelens (#3252)
  fix: Impl methods are no longer placed in contracts (#3255)
  feat(stdlib): optimize constraint counts in sha256/sha512 (#3253)
  chore: enhance code formatting for If expressions (#3246)
  feat: Cache debug artifacts  (#3133)
TomAFrench added a commit that referenced this pull request Oct 24, 2023
* master:
  chore(docs): Rearrange NoirJS section (#3260)
  chore(docs): Document `nargo fmt` (#3262)
  feat(debugger): Print limited source code context (#3217)
  fix: recompile artefacts from a different noir version (#3248)
  chore: Update ACIR artifacts (#3263)
  fix: Show println output before an error occurs in `nargo execute` (#3211)
  chore(docs): document info codelens (#3252)
  fix: Impl methods are no longer placed in contracts (#3255)
  feat(stdlib): optimize constraint counts in sha256/sha512 (#3253)
  chore: enhance code formatting for If expressions (#3246)
  feat: Cache debug artifacts  (#3133)
TomAFrench added a commit that referenced this pull request Oct 24, 2023
* master:
  feat: implement euclidean division and signed division in terms of `AcirVar`s (#3230)
  feat: replace boolean range constraints with arithmetic opcodes (#3234)
  feat!: Switch to new pedersen implementation (#3151)
  feat: noir-wasm takes dependency graph (#3213)
  chore(docs): Rearrange NoirJS section (#3260)
  chore(docs): Document `nargo fmt` (#3262)
  feat(debugger): Print limited source code context (#3217)
  fix: recompile artefacts from a different noir version (#3248)
  chore: Update ACIR artifacts (#3263)
  fix: Show println output before an error occurs in `nargo execute` (#3211)
  chore(docs): document info codelens (#3252)
  fix: Impl methods are no longer placed in contracts (#3255)
  feat(stdlib): optimize constraint counts in sha256/sha512 (#3253)
  chore: enhance code formatting for If expressions (#3246)
  feat: Cache debug artifacts  (#3133)
TomAFrench added a commit that referenced this pull request Oct 24, 2023
* master:
  feat: implement euclidean division and signed division in terms of `AcirVar`s (#3230)
  feat: replace boolean range constraints with arithmetic opcodes (#3234)
  feat!: Switch to new pedersen implementation (#3151)
  feat: noir-wasm takes dependency graph (#3213)
  chore(docs): Rearrange NoirJS section (#3260)
  chore(docs): Document `nargo fmt` (#3262)
  feat(debugger): Print limited source code context (#3217)
  fix: recompile artefacts from a different noir version (#3248)
  chore: Update ACIR artifacts (#3263)
  fix: Show println output before an error occurs in `nargo execute` (#3211)
  chore(docs): document info codelens (#3252)
  fix: Impl methods are no longer placed in contracts (#3255)
  feat(stdlib): optimize constraint counts in sha256/sha512 (#3253)
  chore: enhance code formatting for If expressions (#3246)
  feat: Cache debug artifacts  (#3133)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant