chore(docs): Supplement descriptions for defaulting loop indices to be u64#3237
Merged
TomAFrench merged 6 commits intomasterfrom Oct 26, 2023
Merged
chore(docs): Supplement descriptions for defaulting loop indices to be u64#3237TomAFrench merged 6 commits intomasterfrom
u64#3237TomAFrench merged 6 commits intomasterfrom
Conversation
Savio-Sou
added
enhancement
documentation
Contributor
|
I'm a bot, beep boop 🤖 Deployment Status: Success!Preview |
Contributor
|
If you do not supply a type for an integer in Noir, it would not default to u64 -- The PRs that were linked were referring to the index of a for loop |
Collaborator
Author
|
Oh hmm, so we now have different integer type defaults under different scenarios? Sounds like that could get troublesome. |
signorecello
approved these changes
Oct 24, 2023
TomAFrench
requested changes
Oct 24, 2023
Member
TomAFrench
left a comment
TomAFrench
left a comment
There was a problem hiding this comment.
These docs are inaccurate as mentioned in above messages.
jfecher
reviewed
Oct 25, 2023
Co-authored-by: jfecher <jake@aztecprotocol.com>
Co-authored-by: jfecher <jake@aztecprotocol.com>
Savio-Sou
changed the title
u64u64
Collaborator
Author
|
PR revised with Jake's suggestions incorporated. |
TomAFrench
approved these changes
Oct 26, 2023
guipublic
pushed a commit
that referenced
this pull request
Oct 27, 2023
…e `u64` (#3237) Co-authored-by: José Pedro Sousa <jose@aztecprotocol.com> Co-authored-by: jfecher <jake@aztecprotocol.com>
guipublic
pushed a commit
that referenced
this pull request
Oct 27, 2023
…e `u64` (#3237) Co-authored-by: José Pedro Sousa <jose@aztecprotocol.com> Co-authored-by: jfecher <jake@aztecprotocol.com>
guipublic
pushed a commit
that referenced
this pull request
Oct 30, 2023
…e `u64` (#3237) Co-authored-by: José Pedro Sousa <jose@aztecprotocol.com> Co-authored-by: jfecher <jake@aztecprotocol.com>
TomAFrench
added a commit
that referenced
this pull request
Oct 30, 2023
* master: (242 commits) chore(docs): Update Windows installation (#3326) chore!: change stdlib function `pedersen` to `pedersen_commitment` (#3341) chore: add back algolia recrawler (#3332) chore: comment out algolia recrawler workflow as its failing master (#3331) chore: Modify single line if-else expression width threshold (#3329) feat: Expand trait impl overlap check to cover generic types (#3320) feat: Implement where clauses on impls (#3324) chore: builtin wrapping shift left (#3270) chore: format integration tests (#3257) fix(3300): cache warnings into debug artefacts (#3313) fix(3275): activate brillig modulo test with negative integers (#3318) feat: Add check for overlapping generic traits (#3307) feat: Refactor debugger and separate core from UI (#3308) chore: recrawl docs on merge (#3306) chore: add bn254 attribute when needed in the stdlib (#3208) feat: add exports of JS black box solvers to noirJS (#3295) chore: upload acir artifacts as a github artifact (#3288) chore: bump bb version to 0.12.0 (#3304) chore(docs): Supplement descriptions for defaulting loop indices to be `u64` (#3237) chore: create publish-docs.yml (#3298) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary*
Following #2764 and noir-lang/docs@7bb178d, this PR:
Removes the mentioning of(inaccurate)Fieldas the default integer type from the "Fields" doc pageu64being the default integer type for loops in the "Integers" doc pagePR Checklist*
cargo fmton default settings.