-
Notifications
You must be signed in to change notification settings - Fork 381
feat: perform compile-time euclidean division on constants #3231
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
83b6a62
chore: implement signed division in terms of `AcirVar`s
TomAFrench 880c461
chore: implement more-than-eq in terms of `AcirVar`s
TomAFrench d1ef394
chore: add `add_mul_var` helper method
TomAFrench 94e5083
chore: implement euclidean division in terms of `AcirVar`s
TomAFrench 0d9bd98
chore: update artifacts
TomAFrench e7688a5
feat: perform constant euclidean division at compile-time
TomAFrench 4c558fd
chore: update artifacts
TomAFrench 73d1c01
Merge branch 'master' into tf/acir-var-euclid
TomAFrench 5a61783
Merge branch 'tf/acir-var-euclid' into tf/optimize-constant-div
TomAFrench 3a8fe3f
Merge branch 'master' into tf/optimize-constant-div
TomAFrench 49a30c5
Merge branch 'master' into tf/optimize-constant-div
TomAFrench c289721
chore: short-circuit division by 1
TomAFrench 7db6390
chore: typos
TomAFrench 67797dc
Merge branch 'master' into tf/optimize-constant-div
TomAFrench File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binary file modified
BIN
-244 Bytes
(100%)
tooling/nargo_cli/tests/acir_artifacts/conditional_1/target/acir.gz
Binary file not shown.
Binary file modified
BIN
-36 Bytes
(100%)
tooling/nargo_cli/tests/acir_artifacts/conditional_1/target/witness.gz
Binary file not shown.
Binary file modified
BIN
+1 Byte
(100%)
tooling/nargo_cli/tests/acir_artifacts/simple_shield/target/acir.gz
Binary file not shown.
Binary file modified
BIN
-189 Bytes
(99%)
tooling/nargo_cli/tests/acir_artifacts/slice_dynamic_index/target/acir.gz
Binary file not shown.
Binary file modified
BIN
-40 Bytes
(100%)
tooling/nargo_cli/tests/acir_artifacts/slice_dynamic_index/target/witness.gz
Binary file not shown.
Binary file modified
BIN
-4 Bytes
(100%)
tooling/nargo_cli/tests/acir_artifacts/slices/target/acir.gz
Binary file not shown.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.