feat: Allow step debugging inside Brillig blocks#3155
Closed
ggiraldez wants to merge 4 commits intonoir-lang:masterfrom
Closed
feat: Allow step debugging inside Brillig blocks#3155ggiraldez wants to merge 4 commits intonoir-lang:masterfrom
ggiraldez wants to merge 4 commits intonoir-lang:masterfrom
Conversation
Member
|
Will try to take a look at this today. |
5 tasks
Contributor
Author
|
This functionality was implemented by #3259 taking a different approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When running the debugger and stepping through a Brillig block, execute each Brillig opcode step by step.
Part of #3015.
Problem
Before this PR, the debugger step command would execute the full Brillig block when stepping through it.
Summary
Documentation
This PR requires documentation updates when merged.
Additional Context
I'm not 100% happy with the API, especially due to the use of boolean values to distinguish between the two modes of execution, but the resulting code is pretty compact and backwards compatible.
PR Checklist
cargo fmton default settings.